Open
Conversation
I missed this in PRs chromium#131 and chromium#135.
Collaborator
Author
|
Weird - https://github.com/chromium/hstspreload/actions/runs/5535335852 is the CI run from PR #135 that shows the failure of a test here. However, that PR also shows a CI run that's successful. |
Collaborator
|
Huh, I wonder if something changed from the httpbin side temporarily. Anyways, this LGTM since it still makes sense to skip the test (also, sorry that I missed this until now) |
Collaborator
Author
|
I don't think I sent this for review. I'm thinking instead of continuing to play whack-a-mole with tests like this, if we should just disable all tests that connect to external domains until #112 is resolved. |
Collaborator
|
Ack, one day I'll learn to use github for code review 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this in PRs #131 and #135.